Lesson3 hw #3
Open
Lesson3 hw #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OKrylov
approved these changes
Feb 20, 2019
OKrylov
left a comment
OKrylov
left a comment
There was a problem hiding this comment.
В целом все отлично, по коду и логике программы замечаний нет
|
|
||
| public class DequeImplement<E extends Object > extends QueueImplement<E> { | ||
|
|
||
| public static final int DEFAULT_REAR = -1; |
There was a problem hiding this comment.
у вас идет дублирование констант и полей из QueueImplement, поэтому методы isEmpty и т.д. методы не работали корректно. Нужно переиспользовать все поля из родительского класса.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Весь мозг сломал пока добился чтоб были только последние изменения а не все подряд)).
Ладно, вопрос у меня следующий: класс дек создал как наследник класса кью, чтоб не дублировать методы isEmpty(), isFull() и size() , однако без них цикл while (!dec.isEmpty()) { System.out.println(removeRight(dec)); } из мейна не работает, когда добавил эти методы в Дек то все заработало. Можете пояснить почему так, где я недопонимаю логику наследования?